Deduplicate metadata in Prometheus Remote Write 2.0 requests - #7760
Merged
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
changed the title
friedrichg
approved these changes
Aug 18, 2026
friedrichg
left a comment
friedrichg
left a comment
Member
There was a problem hiding this comment.
LGTM, only a nit in the Changelog
| * [ENHANCEMENT] Compactor: Reduce object storage GET calls when updating the bucket index by skipping re-reading parquet converter markers for blocks that already have a valid-version parquet entry in the previous index. #7669 | ||
| * [ENHANCEMENT] Upgrade Thanos and promql-engine to latest. #7740 | ||
| * [ENHANCEMENT] Ruler: Adjust ruler frontend decoder to not wrap query error messages with execution prefix, this makes error responses consistent between internal and external ruler paths. #7741 | ||
| * [ENHANCEMENT] Distributor: Deduplicate metric metadata when converting Prometheus Remote Write 2.0 requests. PRW 2.0 attaches metadata to every series, so a metric family was previously expanded into one `MetricMetadata` per series. #7759 |
Member
There was a problem hiding this comment.
Suggested change
| * [ENHANCEMENT] Distributor: Deduplicate metric metadata when converting Prometheus Remote Write 2.0 requests. PRW 2.0 attaches metadata to every series, so a metric family was previously expanded into one `MetricMetadata` per series. #7759 | |
| * [ENHANCEMENT] Distributor: Deduplicate metric metadata when converting Prometheus Remote Write 2.0 requests. PRW 2.0 attaches metadata to every series, so a metric family was previously expanded into one `MetricMetadata` per series. #7760 |
4 tasks
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Deduplicate metric metadata when converting Prometheus Remote Write 2.0 requests. PRW 2.0 attaches metadata to every series, so a metric family was previously expanded into one
MetricMetadataper series.Because metadata counts towards the ingestion rate limit, tenants using remote write 2.0 consumed roughly twice their configured
-distributor.ingestion-rate-limitfor the same data.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags